Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add escaping to strings #51

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Add escaping to strings #51

wants to merge 2 commits into from

Conversation

ivan-v-kush
Copy link

pgauditlogtofile logs system events. This events may contain the comma. Or comma may appear during translation (see *.po files). csv file parsing will be broken in such cases. That's why we need to escape strings

@ivan-v-kush
Copy link
Author

@fmbiete maybe also add 2 GUCs?

  • escape symbol GUC
  • delimiter symbol GUC
    Also check during parsing they aren't equal

@ivan-v-kush
Copy link
Author

ivan-v-kush commented Jan 9, 2025 •
edited
Loading

@fmbiete @tacho @nvthongswansea hello. What do you think about this MR?

@ivan-v-kush
don't escape edata->message
05e0c13 
edata->message is a string, that contains entities separated by a comma: SESSION,1,1,ROLE,..,...
If escape it, csv-parser will be broken as entities will not be escaped, only full string
"SESSION,1,1,ROLE,..,..".
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@ivan-v-kush